Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MACCs from Harmen et al 2019 PBL #195

Merged
merged 8 commits into from
Jun 19, 2020
Merged

MACCs from Harmen et al 2019 PBL #195

merged 8 commits into from
Jun 19, 2020

Conversation

flohump
Copy link
Contributor

@flohump flohump commented Jun 18, 2020

updated maccs for the 57_maccs module.
The new maccs from Harmsen et al 2019 have the same structure as the older maccs from Lucas et al 2007.
Old maccs from Lucas et al 2007 are still available and are still default (for compatibility with REMIND).

Unknown-34

@flohump flohump added enhancement New feature or request Minor Smaller modifications Low risk Low risk labels Jun 18, 2020
@flohump flohump requested a review from abhimishr June 19, 2020 09:38
abhimishr
abhimishr previously requested changes Jun 19, 2020
View reviewed changes
Copy link
Member

@abhimishr abhimishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change but then good to go

modules/57_maccs/on_sep16/input.gms Show resolved Hide resolved
tscheypidi
tscheypidi approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@tscheypidi tscheypidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no additional comments beyond what Abhi already pointed out

@flohump flohump dismissed abhimishr’s stale review June 19, 2020 12:33

The files are already included.

@flohump flohump merged commit 76d74e7 into magpiemodel:develop Jun 19, 2020
@flohump flohump deleted the f_PBL_MACC branch June 18, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscheypidi tscheypidi tscheypidi approved these changes

@abhimishr abhimishr abhimishr left review comments

@bodirsky bodirsky Awaiting requested review from bodirsky

Assignees
No one assigned
Labels
enhancement New feature or request Low risk Low risk Minor Smaller modifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flohump @tscheypidi @abhimishr