Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated CHANGELOG.md and CITATION.cff #222

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

tscheypidi
Copy link
Member

@tscheypidi tscheypidi commented Sep 15, 2020

Purpose of this PR

  • updated CHANGELOG.md and CITATION.cff to be prepared for new developments

Performance loss/gain from current default behavior

  • does not apply

Type of change

  • Bug fix (Change which fixes an issue).
  • New feature (Change which adds functionality).
  • Minor change (Change which does not modify core model code i.e., in /modules).
  • Major change (fix or feature that would change current model behavior).

How Has This Been Tested?

  • Runs using starting script which tests current defaults (using test_runs.R).
  • Runs using starting script which successfully runs the same scenarios as in test_runs.R but with the changes from PR.
  • (If applicable) Runs using different scenarios/mappings which are not the default (12 regions/c200 clusters).

Additions or Changes to default configuration (default.cfg):

Additions are the introduction of new model components in default config

Changes are deletion or updates to the existing model components in default config

  • Realizations:
  • Scenario switches:
  • Scalars/Constants:
  • Model interfaces:
  • Others:

Checklist:

  • Self-review of my own code.
  • Added changes to CHANGELOG.md
  • No hard coded numbers and cluster/country/region names.
  • The code doesn't contain declared but unused parameters or variables.
  • In-code comments added including documentation comments.
  • Compiled and checked resulting documentation with goxygen::goxygen() for the new/updated parts.
  • Changes to magpie4 R library for post processing of model output (ideally backward compatible).

Special comments/warnings

  • nice to have the template now in place by default!

Copy link
Member

@abhimishr abhimishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 👍

@abhimishr abhimishr merged commit 774babb into magpiemodel:develop Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants