Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Dockerfile to MAgPIE #224

Merged
merged 12 commits into from
Sep 29, 2020
Merged

Add a Dockerfile to MAgPIE #224

merged 12 commits into from
Sep 29, 2020

Conversation

giannou
Copy link
Contributor

@giannou giannou commented Sep 28, 2020

Please fill following information
(Add additional info if you think its important and not covered by this Pull Request (PR)):

Purpose of this PR

  • Add the possibility of running MAgPIE in a container

Performance loss/gain from current default behavior

  • Add an image using plot from shinyresults::appResults() and annotate accordingly.

  • %performance loss/gain = 100*Runtime from PR/Runtime from current default from develop branch.

Type of change

  • Bug fix (Change which fixes an issue).
  • New feature (Change which adds functionality).
  • Minor change (Change which does not modify core model code i.e., in /modules).
  • Major change (fix or feature that would change current model behavior).

How Has This Been Tested?

  • Runs using starting script which tests current defaults (using test_runs.R).
  • Runs using starting script which successfully runs the same scenarios as in test_runs.R but with the changes from PR.
  • (If applicable) Runs using different scenarios/mappings which are not the default (12 regions/c200 clusters).

Additions or Changes to default configuration (default.cfg):

Additions are the introduction of new model components in default config

Changes are deletion or updates to the existing model components in default config

  • Realizations:
  • Scenario switches:
  • Scalars/Constants:
  • Model interfaces:
  • Others:

Checklist:

  • Self-review of my own code.
  • Added changes to CHANGELOG.md
  • No hard coded numbers and cluster/country/region names.
  • The code doesn't contain declared but unused parameters or variables.
  • In-code comments added including documentation comments.
  • Compiled and checked resulting documentation with goxygen::goxygen() for the new/updated parts.
  • Changes to magpie4 R library for post processing of model output (ideally backward compatible).

Special comments/warnings

  • Notes

@giannou giannou changed the title Develop Add a Dockerfile to MAgPIE Sep 28, 2020
@giannou giannou marked this pull request as draft September 28, 2020 11:48
@giannou giannou marked this pull request as ready for review September 28, 2020 11:49
Copy link
Member

@abhimishr abhimishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the gamslice.txt file in gitignore. As this has to be copied to the main folder for using Docker we don't want people accidentally commiting/adding the GAMS licence file to the repo.

Copy link
Member

@tscheypidi tscheypidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@tscheypidi tscheypidi merged commit d452139 into magpiemodel:develop Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants