-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Dockerfile to MAgPIE #224
Conversation
added pandoc support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add the gamslice.txt
file in gitignore
. As this has to be copied to the main folder for using Docker we don't want people accidentally commiting/adding the GAMS licence file to the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
Please fill following information
(Add additional info if you think its important and not covered by this Pull Request (PR)):
Purpose of this PR
Performance loss/gain from current default behavior
Add an image using plot from
shinyresults::appResults()
and annotate accordingly.%performance loss/gain = 100*Runtime from PR/Runtime from current default from develop branch.
Type of change
How Has This Been Tested?
test_runs.R
).test_runs.R
but with the changes from PR.Additions or Changes to default configuration (default.cfg):
Additions are the introduction of new model components in default config
Changes are deletion or updates to the existing model components in default config
Checklist:
CHANGELOG.md
goxygen::goxygen()
for the new/updated parts.magpie4
R library for post processing of model output (ideally backward compatible).Special comments/warnings