Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Hotfix 🚨 for the failing climate change runs due to a division by zero error in plantation yield scaling calculation. #229

Merged
merged 5 commits into from
Oct 30, 2020

Conversation

abhimishr
Copy link
Member

Purpose of this PR

🚨 Hotfix 🚨 for the failing climate change runs due to a division by zero error in plantation yield scaling calculation.

Performance loss/gain from current default behavior

  • Add an image using plot from shinyresults::appResults() and annotate accordingly.
    image

Performance loss = 11%

Type of change

  • [✔] Bug fix (Change which fixes an issue).
  • [❌] New feature (Change which adds functionality).
  • [❌] Minor change (Change which does not modify core model code i.e., in /modules).
  • [❌] Major change (fix or feature that would change current model behavior).

How Has This Been Tested?

  • [❌] Runs using starting script which tests current defaults (using test_runs.R).
  • [❌] Runs using starting script which successfully runs the same scenarios as in test_runs.R but with the changes from PR.
  • [❌] (If applicable) Runs using different scenarios/mappings which are not the default (12 regions/c200 clusters).

Additions or Changes to default configuration (default.cfg):

Additions are the introduction of new model components in default config

Changes are deletion or updates to the existing model components in default config

  • [❌] Realizations:
  • [❌] Scenario switches:
  • [❌] Scalars/Constants:
  • [❌] Model interfaces:
  • [❌] Others:

Checklist:

  • [✔] Self-review of my own code.
  • [❌] Added changes to CHANGELOG.md
  • [✔] No hard coded numbers and cluster/country/region names.
  • [✔] The code doesn't contain declared but unused parameters or variables.
  • [✔] In-code comments added including documentation comments.
  • [✔] Compiled and checked resulting documentation with goxygen::goxygen() for the new/updated parts.
  • [❌] Changes to magpie4 R library for post processing of model output (ideally backward compatible).

Special comments/warnings

👉 None of the above testing scripts were used but a cc and nocc run was made instead with SSP2 scenario. 👈

@abhimishr abhimishr changed the title Develop 🚨 Hotfix 🚨 for the failing climate change runs due to a division by zero error in plantation yield scaling calculation. Oct 29, 2020
@tscheypidi tscheypidi merged commit ae9e09d into magpiemodel:develop Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants