Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half Earth Protection Scenario #234

Merged
merged 6 commits into from
Dec 9, 2020

Conversation

FelicitasBeier
Copy link
Member

@FelicitasBeier FelicitasBeier commented Dec 4, 2020

Please fill following information
(Add additional info if you think its important and not covered by this Pull Request (PR)):

Purpose of this PR

  • Including new Protection Scenario (provided by IMAGE model: HalfEarth protection)

Performance loss/gain from current default behavior

half_earth

  • 10% gain = 100*0.69/0.76 (when HalfEarth protection scenario selected rather than default)

Type of change

  • Bug fix (Change which fixes an issue).
  • New feature (Change which adds functionality).
  • Minor change (Change which does not modify core model code i.e., in /modules).
  • Major change (fix or feature that would change current model behavior).

How Has This Been Tested?

  • Runs using starting script which tests current defaults (using test_runs.R).
  • Runs using starting script which successfully runs the same scenarios as in test_runs.R but with the changes from PR.
  • (If applicable) Runs using different scenarios/mappings which are not the default (12 regions/c200 clusters).

Additions or Changes to default configuration (default.cfg):

Additions are the introduction of new model components in default config

  • New scenario option "HalfEarth" added in default.cfg in section 35

Changes are deletion or updates to the existing model components in default config

  • Realizations:
  • Scenario switches:
  • Scalars/Constants:
  • Model interfaces:
  • Others: just new scenario added

Checklist:

  • Self-review of my own code.
  • Compilation check (model starts without compilation errors).
  • Added changes to CHANGELOG.md
  • No hard coded numbers and cluster/country/region names.
  • The code doesn't contain declared but unused parameters or variables.
  • In-code comments added including documentation comments.
  • Compiled and checked resulting documentation with goxygen::goxygen() for the new/updated parts.
  • Changes to magpie4 R library for post processing of model output (ideally backward compatible).

Special comments/warnings

  • Notes

Copy link
Contributor

@flohump flohump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does HalfEarth provide any information about the protected land type within a grid cell?
What is the original resolution of HalfEarth?

modules/35_natveg/dynamic_may20/presolve.gms Show resolved Hide resolved
@flohump
Copy link
Contributor

flohump commented Dec 7, 2020

You have to resovle a conflict in changelog.md before I can approve this PR. I will also request a review from RSE @tscheypidi

@FelicitasBeier
Copy link
Member Author

You have to resovle a conflict in changelog.md before I can approve this PR. I will also request a review from RSE @tscheypidi

Done

@FelicitasBeier FelicitasBeier merged commit f9f418a into magpiemodel:develop Dec 9, 2020
FelicitasBeier added a commit to FelicitasBeier/magpie that referenced this pull request Dec 9, 2020
Merge pull request magpiemodel#234 from FelicitasBeier/develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants