-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GAINS output script #253
Merged
Merged
GAINS output script #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodirsky
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill following information
(Add additional info if you think its important and not covered by this Pull Request (PR)):
Purpose of this PR
Performance loss/gain from current default behavior
No performance change, only an output script
Add an image using plot from
shinyresults::appResults()
and annotate accordingly.%performance loss/gain = 100*Runtime from PR/Runtime from current default from develop branch.
Type of change
How Has This Been Tested?
test_runs.R
).test_runs.R
but with the changes from PR.Additions or Changes to default configuration (default.cfg):
Additions are the introduction of new model components in default config
Changes are deletion or updates to the existing model components in default config
Checklist:
CHANGELOG.md
goxygen::goxygen()
for the new/updated parts.magpie4
R library for post processing of model output (ideally backward compatible).Special comments/warnings