Managed pastures tau #372

mppalves · 2022-01-30T20:15:31Z

🐦 Purpose of this PR 🐦

Managed pastures implementation PR 1: Added a new tau dimension for managed pastures.

🔧 Checklist for PR creator 🔧

Labeling pull request correctly from the label list.

Low risk : Simple bugfixes (missing files, updated documentation, typos) or Start/output scripts
Medium risk : New realization / Changes to existing realization / Other changes which don't modify default.cfg
High risk : New input files (if cfg$input is changed in default.cfg) / Modification to core model (eg. changes in equations, calculations, introduction of new sets etc.) / Other changes in default.cfg

Providing additional information based on PR label

Low risk : No new model run needed.
Medium risk : Default run based on the current version of the fork from which PR is made
High risk
- Default run from the current develop branch: /p/projects/landuse/users/pedrosa/MAgPIE/develop_clean/output/default_2022-01-30_17.04.22
- Default run based on the current version of the fork from which PR is made: /p/projects/landuse/users/pedrosa/MAgPIE/MAgPIE_clean/output/default_2022-01-30_16.11.39

⚠️ Additional notes or warnings ⚠️

NA

🚨 Checklist for RSE reviewer 🚨

PR is labeled correctly.
CHANGELOG is updated correctly
No hard coded numbers and cluster/country/region names.
No unnecessary increase in module interfaces
All required updates in interfaces (if any) have been properly adressed in the module contracts
In-code comments and documentation comments are satisfactory.
model behavior/performance is satisfactory.
Requested changes (if any) were applied correctly

🚨 Checklist for MAgPIE reviewer 🚨

PR is labeled correctly.
CHANGELOG is updated correctly
No hard coded numbers and cluster/country/region names.
Changes to the model are scientifically sound
In-code comments and documentation comments are satisfactory.
model behavior/performance is satisfactory.
Requested changes (if any) were applied correctly

cleaning develop

config/default.cfg

emolinab · 2022-01-31T06:36:33Z

CHANGELOG.md


 ### added
+ - **tc** added new set 'tautype' spliting tau between croplands and managed pastures; New input file f13_pastr_tau_hist.csv


It is not very clear to me (only by seeing the changelog) the role of the .csv file (also for the parameters and .cs3 in land). You could instead add a brief description of it? Something like: new input file which contains historical tc for pasture.

emolinab · 2022-01-31T06:37:26Z

config/default.cfg

@@ -49,7 +49,8 @@ cfg$input <- c(regional    = "rev4.67_h12_magpie.tgz",
 #below it will get merged into cfg$repositories

 cfg$repositories <- append(list("https://rse.pik-potsdam.de/data/magpie/public"=NULL),
-                           getOption("magpie_repos"))
+                            getOption("magpie_repos"))
+                          #  list("C:/magpie_inputdata/output"=NULL))


Commented line is maybe coming from a merge?

main.gms

emolinab · 2022-01-31T07:02:52Z

modules/13_tc/endo_jun18/declarations.gms

- pc13_tcguess(h)             Guess for annual tc rates in the next time step (1)
- i13_tc_factor(t)            Regression factor (USD05PPP per ha)
- i13_tc_exponent(t)          Regression exponent (1)
+ pc13_land(i, tautype)                Crop land area per region (mio ha)


Description change, Now it includes pasture as well

modules/10_land/feb15/declarations.gms

flohump

Great to see this development moving!
Just for clarification. With this PR you add data sets and dimensions for managed pasture. But these additions are not yet used, right?
For instance, pasture is not yet split and pasture yields are not yet changed. Is that correct?
If I'm not mistaken vm_tau(i,"pastr") is currently a free variable.

mppalves · 2022-01-31T13:54:13Z

Great to see this development moving! Just for clarification. With this PR you add data sets and dimensions for managed pasture. But these additions are not yet used, right? For instance, pasture is not yet split and pasture yields are not yet changed. Is that correct? If I'm not mistaken vm_tau(i,"pastr") is currently a free variable.

Hi Florian! Yes, I am splitting the whole implementation into chunks. This is the first chunk of code, so vm_tau(i, "past") is still not engaged in any other module. It will be once all the other parts are put together! So, for this PR no significant changes in model behaviors are expected.

tscheypidi · 2022-01-31T13:59:00Z

modules/11_costs/default/equations.gms

@@ -16,7 +16,7 @@
                   + vm_cost_inv(i2)
                   + sum((cell(i2,j2),land), vm_cost_landcon(j2,land))
                   + sum((cell(i2,j2),k), vm_cost_transp(j2,k))
-                   + vm_tech_cost(i2)
+                   + sum(tautype, vm_tech_cost(i2,tautype))


don't do that. You will introduce various compatibility issues by changing the declaration of an interface. You can instead sum up the costs within the tc module and leave the vm_tech_cost interface untouched

tscheypidi · 2022-01-31T14:01:22Z

modules/13_tc/endo_jun18/declarations.gms

- v13_cost_tc(i)              Technical change costs per region (mio. USD05PPP)
+ vm_tau(h,tautype)                   Agricultural land use intensity tau (1)
+ vm_tech_cost(i,tautype)             Annuitized costs of TC (mio. USD05PPP per yr)
+ v13_cost_tc(i,tautype)              Technical change costs per region (mio. USD05PPP)
 ;


your implementation is completely different to what is there so far. Hence, you need to create a new realization and do your changes in this new realization.

and try to reduce your changes in the interfaces! Changing interfaces will introduce a lot of work, e.g. a lot of changes in the magpie4 package and so on

tscheypidi · 2022-01-31T14:03:57Z

modules/10_land/feb15/declarations.gms

@@ -9,6 +9,7 @@
 parameters
 pm_land_start(j,land)            Land initialization area (mio. ha)
 pcm_land(j,land)                 Land area in previous time step (mio. ha)
+ pcm_grass(j,grassland)           Grassland areas in previous time step (mio. ha)


I don't think that you need that additional interface...in the tc module you could use pcm_land("past") instead even so it has a slightly different meaning

mppalves and others added 6 commits January 28, 2022 15:15

Merge pull request #20 from magpiemodel/develop

c398bb9

cleaning develop

new tau realization

70eab12

new tau realization

600c319

new tau realization

b2a02ab

removing old tc realizaton

048111c

update input and changelog

7ebbcd3

mppalves added enhancement New feature or request Minor Smaller modifications High risk Higher risk labels Jan 30, 2022

mppalves requested review from tscheypidi, flohump and emolinab January 30, 2022 20:15

emolinab requested changes Jan 31, 2022

View reviewed changes

mppalves added 2 commits January 31, 2022 12:12

Addressing edna's comments

11aa4af

changing main

c82b99e

flohump reviewed Jan 31, 2022

View reviewed changes

tscheypidi requested changes Jan 31, 2022

View reviewed changes

mppalves closed this Mar 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Managed pastures tau #372

Managed pastures tau #372

mppalves commented Jan 30, 2022

emolinab Jan 31, 2022

emolinab Jan 31, 2022

emolinab Jan 31, 2022

flohump left a comment

mppalves commented Jan 31, 2022 •

edited

Loading

tscheypidi Jan 31, 2022

tscheypidi Jan 31, 2022

tscheypidi Jan 31, 2022

tscheypidi Jan 31, 2022


		### added
		- tc added new set 'tautype' spliting tau between croplands and managed pastures; New input file f13_pastr_tau_hist.csv

Managed pastures tau #372

Managed pastures tau #372

Conversation

mppalves commented Jan 30, 2022

🐦 Purpose of this PR 🐦

🔧 Checklist for PR creator 🔧

⚠️ Additional notes or warnings ⚠️

🚨 Checklist for RSE reviewer 🚨

🚨 Checklist for MAgPIE reviewer 🚨

emolinab Jan 31, 2022

Choose a reason for hiding this comment

emolinab Jan 31, 2022

Choose a reason for hiding this comment

emolinab Jan 31, 2022

Choose a reason for hiding this comment

flohump left a comment

Choose a reason for hiding this comment

mppalves commented Jan 31, 2022 • edited Loading

tscheypidi Jan 31, 2022

Choose a reason for hiding this comment

tscheypidi Jan 31, 2022

Choose a reason for hiding this comment

tscheypidi Jan 31, 2022

Choose a reason for hiding this comment

tscheypidi Jan 31, 2022

Choose a reason for hiding this comment

mppalves commented Jan 31, 2022 •

edited

Loading