Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop clean 32 #378

Closed
wants to merge 23 commits into from
Closed

Conversation

mppalves
Copy link
Contributor

@mppalves mppalves commented Feb 28, 2022

Please fill following information
(Add additional info if you think its important and not covered by this Pull Request (PR)):

Purpose of this PR

This pull request implements a new realization of module 31_past that allows the separation of grass biomass production into areas of managed pastures and rangelands. It also updates module 13_tc adding a new set that distinguishes tau that is applied to managed pastures vs tau applied to crops.

Performance loss/gain from current default behavior

  • Add an image using plot from shinyresults::appResults() and annotate accordingly.

runtime

  • %performance loss/gain = 100*Runtime from PR/Runtime from current default from develop branch.
    33% performance loss.

Type of change

  • Bug fix (Change which fixes an issue).
  • New feature (Change which adds functionality).
  • Minor change (Change which does not modify core model code i.e., in /modules).
  • Major change (fix or feature that would change current model behavior).

How Has This Been Tested?

  • Runs using starting script which tests current defaults (using test_runs.R).
  • Runs using starting script which successfully runs the same scenarios as in test_runs.R but with the changes from PR.
  • [] (If applicable) Runs using different scenarios/mappings which are not the default (12 regions/c200 clusters).

Testes with different combinations of the realizations affected by the change:

download (1)
download (2)

Testes with different ssp scenarios as in test_runs.R:
download (4)

download (5)

Additions or Changes to default configuration (default.cfg):

Additions are the introduction of new model components in default config

Changes are deletion or updates to the existing model components in default config

  • Realizations:
  • Scenario switches:
  • Scalars/Constants:
  • Model interfaces:
  • Others:

Checklist:

  • Self-review of my own code.
  • Compilation check (model starts without compilation errors).
  • Added changes to CHANGELOG.md
  • No hard coded numbers and cluster/country/region names.
  • The code doesn't contain declared but unused parameters or variables.
  • In-code comments added including documentation comments.
  • Compiled and checked resulting documentation with goxygen::goxygen() for the new/updated parts.
  • Changes to magpie4 R library for post processing of model output (ideally backward compatible).

Special comments/warnings

  • Notes

@mppalves mppalves added enhancement New feature or request High risk Higher risk Major Substantial modifications labels Feb 28, 2022
@tscheypidi
Copy link
Member

What did you compare in your performance test? It looks like to compared the new pasture realization with the old one? Does that mean that the new pasture realization should be the new default? If it is not meant to be the new default you need to compare a current develop run with a run with your version but default settings

@mppalves
Copy link
Contributor Author

mppalves commented Mar 1, 2022

I made two sets of runs. One is permutating over the altered realizations. In this case the realization names are in the title of the run. In the second set, I'm running the new realizations for different SSP scenarios, as requested by 'test_run.R'. (apparently not part of the current PR template).

The new realization for module 13_tc/endo_dec22 is replacing 13_tc/endo_jun18 as they are incompatible. So, the new default would be the run under the name 13_tc/endo_dec22 and 31_past/endo_jun13: "test1-endo_dec22_endo_jun13".

@mppalves mppalves closed this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request High risk Higher risk Major Substantial modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants