-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop clean 32 #378
Develop clean 32 #378
Conversation
What did you compare in your performance test? It looks like to compared the new pasture realization with the old one? Does that mean that the new pasture realization should be the new default? If it is not meant to be the new default you need to compare a current develop run with a run with your version but default settings |
The new realization for module 13_tc/endo_dec22 is replacing 13_tc/endo_jun18 as they are incompatible. So, the new default would be the run under the name 13_tc/endo_dec22 and 31_past/endo_jun13: "test1-endo_dec22_endo_jun13". |
Please fill following information
(Add additional info if you think its important and not covered by this Pull Request (PR)):
Purpose of this PR
This pull request implements a new realization of module 31_past that allows the separation of grass biomass production into areas of managed pastures and rangelands. It also updates module 13_tc adding a new set that distinguishes tau that is applied to managed pastures vs tau applied to crops.
Performance loss/gain from current default behavior
shinyresults::appResults()
and annotate accordingly.33% performance loss.
Type of change
How Has This Been Tested?
test_runs.R
).test_runs.R
but with the changes from PR.Testes with different combinations of the realizations affected by the change:
Testes with different ssp scenarios as in test_runs.R:
Additions or Changes to default configuration (default.cfg):
Additions are the introduction of new model components in default config
Changes are deletion or updates to the existing model components in default config
Checklist:
CHANGELOG.md
goxygen::goxygen()
for the new/updated parts.magpie4
R library for post processing of model output (ideally backward compatible).Special comments/warnings