-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grassland management implementation #379
Conversation
…into develop_clean_32
…as and correction on the expansion cost calculation
…into develop_clean_32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks quite good now. Just one additional suggestion for further simplification and two questions concerning some mz-files which are now being copied to the modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
🐦 Purpose of this PR 🐦
This pull request implements a new realization of module 31_past that allows the separation of grass biomass production into areas of managed pastures and rangelands. It also updates module 13_tc adding a new set that distinguishes tau that is applied to managed pastures vs tau applied to crops.
🔧 Checklist for PR creator 🔧
default_dev_mar22
default_new_mar22 - New default
IPSL-CM6A-LR-SSP2-set18 - New Realization ON
📉 Performance loss/gain from current default behavior 📈
Added changes to
CHANGELOG.md
Compilation check (model starts without compilation errors - use
gams main.gms action=c
in model folder for testing).No hard coded numbers and cluster/country/region names.
The new code doesn't contain declared but unused parameters or variables.
Where relevant, In-code comments added including documentation comments.
Made sure that documentation created with
goxygen
is okay (usegoxygen::goxygen()
for testing).Changes to
magpie4
R library for post processing of model output (ideally backward compatible).Self-review of my own code.
For high risk runs: validation of major model indicators - Land-use, emissions, food prices, Tau.
=======================================================================
**Below find the results comparing the current default and the new implementation: **
The blue line is the current develop (old TC module and old pasture module)
The red line is the new proposed default (new TC module and old pasture module)
The green line is the new implementation (new TC and new pasture modules)
NA
🚨 Checklist for RSE reviewer 🚨
CHANGELOG
is updated correctly🚨 Checklist for MAgPIE reviewer 🚨
CHANGELOG
is updated correctly