-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new land realization (transition matrix) and rewrite of the som module #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
k4rst3ns
commented
Aug 8, 2019
- include new land realization featuring land transition matrix
- include rewrite of som module featuring update of carbon stocks via som module
- smaller changes in other modules to remove soil carbon related calculations there and bundle them in som
- new settings for ghg_policy (including bugfix of old ssp default setting, which overestimates soil emissions)
…herefor change realization name to static_jan19
flohump
reviewed
Aug 14, 2019
flohump
reviewed
Aug 14, 2019
flohump
reviewed
Aug 14, 2019
flohump
approved these changes
Aug 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the "land" and the "som" module seem fine to me.
I only have some minor comments.
flohump
pushed a commit
to flohump/magpie
that referenced
this pull request
Mar 17, 2023
speed up plotIntercomparison tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.