Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use writeVarInt for enum ordinals #95

Closed
shevek opened this issue Aug 27, 2018 · 3 comments
Closed

Use writeVarInt for enum ordinals #95

shevek opened this issue Aug 27, 2018 · 3 comments

Comments

@shevek
Copy link

shevek commented Aug 27, 2018

In things like EnumMapSerializer, VarInt encoding is smaller than int encoding for both lengths and ordinal() values. Please prefer it.
@magro
Copy link
Owner

magro commented Nov 26, 2018

Which serializer are you referring to? Do you want to submit a PR?

@shevek
Copy link
Author

shevek commented Dec 1, 2018

https://github.com/magro/kryo-serializers/blob/master/src/main/java/de/javakaffee/kryoserializers/EnumMapSerializer.java#L96

Should use writeVarInt() to save 3 bytes.

@magro
Copy link
Owner

magro commented Dec 1, 2018

Right. As said, feel free to submit a PR!

@magro magro closed this as completed in ca06b9c Dec 9, 2018
magro added a commit that referenced this issue Dec 9, 2018
@magro
Merge pull request #102 from Pr0methean/patch-1
b11df0d 
Fix #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@magro @shevek