Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use idiomatic approach for is_iterable method #215

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use idiomatic approach for is_iterable method #215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39a225a
Use Python idiomatic approach for `is_iterable` method
askoretskiy Jun 21, 2019
3d5e1b2
Use idiomatic code for `is_iterable`
askoretskiy Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions boltons/iterutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,7 @@ def is_iterable(obj):

.. _iterable: https://docs.python.org/2/glossary.html#term-iterable
"""
try:
iter(obj)
except TypeError:
return False
return True
return isinstance(obj, Iterable)


def is_scalar(obj):
Expand All @@ -75,7 +71,7 @@ def is_scalar(obj):
>>> is_scalar('hello')
True
"""
return not is_iterable(obj) or isinstance(obj, basestring)
return not isinstance(obj, Iterable) or isinstance(obj, basestring)


def is_collection(obj):
Expand All @@ -89,7 +85,7 @@ def is_collection(obj):
>>> is_collection('hello')
False
"""
return is_iterable(obj) and not isinstance(obj, basestring)
return isinstance(obj, Iterable) and not isinstance(obj, basestring)


def split(src, sep=None, maxsplit=None):
Expand Down