Test and fix for #348 #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
reviewed
Oct 13, 2023
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
nicoddemus
approved these changes
Oct 13, 2023
|
Hey, thanks for your patience! @markrwilliams, one of the original authors also took a look and gave it a 👍 offline. Just a good old fashioned latent bug. As far as changelogs, I usually hammer those out at release. :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test repro'd #348, plus I checked
.values()for good measure. It wasn't really a supported use case before, but ideally it should be; cacheutil are dict subtypes (for better or worse).Before merging, I should probably add LRI tests for this, just to be safe. Also need to think a little harder about whether there are more invariant tests that need to be added for the linked list.