Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update glom #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Update glom #106

wants to merge 1 commit into from

Conversation

kurtbrose
Copy link
Collaborator

maybe this would be better covered by an improved Partial / Call

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #106 into master will decrease coverage by 0.25%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   95.17%   94.92%   -0.26%     
==========================================
  Files          16       16              
  Lines        1824     1832       +8     
  Branches      270      270              
==========================================
+ Hits         1736     1739       +3     
- Misses         49       54       +5     
  Partials       39       39
Impacted Files Coverage Δ
glom/mutation.py 93.75% <37.5%> (-5.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d6c50...88dd69f. Read the comment docs.

@mahmoud
Copy link
Owner

mahmoud commented Jul 10, 2020

In theory we could allow Merge() to update an existing dict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants