Only supporting Python 3.7+ (including dropping Python 2) #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
- Coverage 98.26% 98.01% -0.25%
==========================================
Files 27 27
Lines 4380 4336 -44
Branches 760 748 -12
==========================================
- Hits 4304 4250 -54
- Misses 48 56 +8
- Partials 28 30 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kurtbrose
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
LGTM! it's made that code coverage went down 0.01% or something but I don't think actual coverage went down, just more covered than not-covered lines were deleted
(maybe because those backport python files counted as 100% covered with the coverage-ignore pragmas?)
|
Alright, I feel like if anyone was going to comment on the PR, a week's time is a pretty solid window. Unsurprisingly uncontroversial so far. Merging for release later this week. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the changelog last month, Python 2 is not long for glom.
Actually supporting the intrinsic idiosyncrasies between the two major versions wasn't so bad. But all the headaches of tools (virtualenv, tox, etc.) and keeping CI running for Py2 slows down releases and definitely makes feature development less fun.
As far as usage, Python 2 represents <1% of
pip installsalmost every day in the available history, according to PyPI stats.Maybe also worth noting that we'd planned to do this for a while, but wanted to wait for a moment when it felt like most of the important features were available. So matching, error traces, scopes, extensions, etc., can still be found in versions <23.2.
Anyways, feel free to chime in. @kurtbrose and I think 2/23 sounds like a great time for glom to go from 2->3. (Get it? two to three, 2 2 3, 2/23 😁 )