Skip to content
This repository has been archived by the owner on Jan 6, 2020. It is now read-only.

Add deadlines to several methods #67

Merged
merged 2 commits into from
Apr 15, 2016

Conversation

canndrew
Copy link
Contributor

This change adds a deadline: time::SteadyTime argument to all blocking methods.

I think there's room for debate about whether this is the right thing to do. But it's certainly useful.


This change is Reviewable

@canndrew
Copy link
Contributor Author

It's probably not worth merging this one for now as rust-1.8 comes out tomorrow and will bring with it a stable Instant type.

I'll update the PR to use Instant tomorrow.

@canndrew
Copy link
Contributor Author

Updated.

r? @vinipsmaker

@vinipsmaker
Copy link
Contributor

Reviewed 13 of 13 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@vinipsmaker vinipsmaker merged commit 49e6a63 into maidsafe-archive:master Apr 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants