-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute GHAs only in maidsafe repository #189
Conversation
As you have noticed, latest version of clippy doesn’t pass diff --git a/src/peer_config.rs b/src/peer_config.rs
index d10a2e6..982e37f 100644
--- a/src/peer_config.rs
+++ b/src/peer_config.rs
@@ -46,11 +46,13 @@ pub fn new_our_cfg(
our_key: quinn::PrivateKey,
) -> Result<quinn::ServerConfig> {
let mut our_cfg_builder = {
- let mut our_cfg = quinn::ServerConfig::default();
- our_cfg.transport = Arc::new(new_transport_cfg(
- idle_timeout_msec,
- keep_alive_interval_msec,
- ));
+ let our_cfg = quinn::ServerConfig {
+ transport: Arc::new(new_transport_cfg(
+ idle_timeout_msec,
+ keep_alive_interval_msec,
+ )),
+ ..Default::default()
+ };
quinn::ServerConfigBuilder::new(our_cfg)
}; Unfortunately this doesn’t compile because Someone from Maidsafe should make a PR to quinn people to change this, unless you find a better solution. |
cargo intraconv changes markdown links to intra-doc links
This fetches a shared deny.toml from the QA repo before running the cargo deny GH Action.
Update thierry ci pr
Forking Maidsafe repositories is a pain because they have GHA workflows that don’t work from other repositories du to secrets used in them. This generates errors and many mails with each push commands.
This PR, defined on qp2p as an example, solves this problem by executing actions only within Maidsafe repository but not in forked ones.
The solution is simple, add the following line to control execution of each action:
if: ${{ github.repository_owner == 'maidsafe' }}
.Additionally, the bad indentation of tag_release.yml has been corrected.