feat: allow override of bootstap cache #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoga07
previously approved these changes
Feb 17, 2021
joshuef
force-pushed
the
Feat-OverrideBootstrap
branch
from
a724920
to
29e7968
Compare
bochaco
reviewed
Feb 17, 2021
src/api.rs
Outdated
| /// Ok(()) | ||
| /// } | ||
| /// ``` | ||
| pub async fn bootstrap( | ||
| &self, | ||
| override_target_addresses: Option<&Vec<SocketAddr>>, |
There was a problem hiding this comment.
I don't think we need the Option just a slice &[SocketAddr], if it's not empty you override.
BREAKING CHANGE: updates `boostrap` api to take optional arg
joshuef
force-pushed
the
Feat-OverrideBootstrap
branch
from
29e7968
to
e0aee65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing in bootstrap contact override
(used in client when attempting to relocate eg)