feat: retry connection attempts for new connections too #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
force-pushed
the
Feat-RetryNewConnections
branch
from
d9d5672
to
897b6bc
Compare
connec
reviewed
Jul 28, 2021
connec
reviewed
Jul 28, 2021
connec
suggested changes
Jul 28, 2021
added 3 commits
July 28, 2021 16:46
We need to debug why this test is taking so long, and there's no reason not to enable the logs, particularly since they're enabled for every other test.
This is how the `backoff` crate supports limiting how long we back off for. The default is 15 mins (!) which is crazy long for our purposes. The configuration is exposed via the `Config` struct under `retry_duration_msec`. The default is 30s, which is completely arbitrary but reasonable-sounding. Retry logic was refactored into a method to make it easier to use the configuration.
Even the default 30s is quite long for tests, so it's been reduced to a trivial time (500ms). Sadly, tests with connection failures still take a long time to run, since that timeout is configured elsewhere (and I couldn't find out where – possibly it's an OS setting).
connec
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.