Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xorname dep #317

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Update xorname dep #317

merged 2 commits into from
Sep 1, 2021

Conversation

oetyng
Copy link
Contributor

@oetyng oetyng commented Aug 31, 2021

Updates xorname and derives debug for channels exposed in public api.

@oetyng oetyng requested a review from a team as a code owner August 31, 2021 20:11
@oetyng oetyng enabled auto-merge (rebase) August 31, 2021 20:13
@@ -21,7 +21,7 @@ thiserror = "1.0.23"
webpki = "~0.21.3"
tiny-keccak = "2.0.2"
tracing = "~0.1.26"
xor_name = "3.0.0"
xor_name = "3.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no harm in it, but it shouldn't be necessary for us to manually bump within major versions, since cargo uses caret requirements by default. Did you need to update it for some reason? (so I can fix my understanding 😄)

Copy link
Contributor Author

@oetyng oetyng Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since cargo uses caret requirements by default

Aha, gravy!

Well, then that update wasn't necessary then 👍 just the derives.

@oetyng oetyng merged commit 4d262de into maidsafe:master Sep 1, 2021
@oetyng oetyng deleted the update-xorname-dep branch September 1, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants