Drop no-igd feature in favour of existing igd feature
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 10, 2021 18:09
Since `igd` is already an optional dependency, we already have an `igd` feature which is enabled by default. To disable IGD, we can simply use `default-features = false` or `--no-default-features`. BREAKING CHANGE: The `no-igd` feature has been removed.
The `Config` struct will no longer have a `port_forward` field if the `igd` feature is not enabled. This removes a case where a user could set the config, but we would ignore it. BREAKING CHANGE: The `port_forward` field on `Config` is only present with the `igd` feature enabled (default).
This ensures we don't accidentally release changes that won't work with the `igd` feature disabled.
bochaco
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b5ee260 refactor!: Remove
no-igdfeatureSince
igdis already an optional dependency, we already have anigdfeature which is enabled by default. To disable IGD, we can simply use
default-features = falseor--no-default-features.BREAKING CHANGE: The
no-igdfeature has been removed.1d9e38d refactor!: Make
Config::port_forwarddepend onigdfeatureThe
Configstruct will no longer have aport_forwardfield if theigdfeature is not enabled. This removes a case where a user could setthe config, but we would ignore it.
BREAKING CHANGE: The
port_forwardfield onConfigis only presentwith the
igdfeature enabled (default).a3ec0b7 ci: Run tests both with and without
igdfeatureThis ensures we don't accidentally release changes that won't work with
the
igdfeature disabled.