Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(launchpad): make sure the correct primary path is used #1925

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix(launchpad): make sure the correct primary path is used #1925

merged 1 commit into from
Jun 26, 2024

Conversation

RolandSherwin
Copy link
Member

@RolandSherwin RolandSherwin commented Jun 26, 2024 •
edited
Loading

Fixes #1888

  • When dealing with unix, every mount point would start with '/'. This would lead to incorrect result when selecting the primary partition. So instead, find the mount point that ends with '/'. This would be our primary partition.
  • Tested on windows and mac, and it works as intended.

@RolandSherwin
fix(launchpad): make sure the correct primary path is used
a484bc5 
- when dealing with unix, every mount point would start with '/', so
instead find the point that ends with '/'. This would be our primary
partition.
@RolandSherwin RolandSherwin changed the title fix(log): specific crate should take more precedence over defaults fr… fix(launchpad): make sure the correct primary path is used Jun 26, 2024
@RolandSherwin RolandSherwin mentioned this pull request Jun 26, 2024
Closed
@jacderida jacderida enabled auto-merge June 26, 2024 13:42
@jacderida jacderida added this pull request to the merge queue Jun 26, 2024
Merged via the queue into maidsafe:main with commit bf6695a Jun 26, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacderida jacderida jacderida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node-launcher gets available disk space wrong on Linux ... sometimes
2 participants
@RolandSherwin @jacderida