-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footnotes in paragraph mode and two columns #655
Comments
I started working in this issue in this branch. At the moment, I copied the section that defines the I add the new arrangement to the example file
The output can be seen in the attached file. The document features a
But I don't see any undefined lenght. Should any of the lenghts here be defined for each specific arrangment? |
I will look this week-end, I hope
Le 13 juin 2017 à 10:17, TeXtnik <notifications@github.com> a écrit :
… I started working in this issue in this branch. At the moment, I copied the section that defines the twocol arrangement and I change the names of the macros to use the new name of the arrangement.
I add the new arrangement to the example file 1-critical-edition.tex. It doesn't compile. The error is:
Section 1 (./1-criticalnotes.1)
! Illegal unit of measure (pt inserted).
<to be read again>
=
l.58 \endnumbering
?
The output can be seen in the attached file.
1-criticalnotes.pdf
The document features a 5000 so I suspect that the error should be in the code block:
***@***.***@insert}[1]{%
***@***.***%
\hsize \csuse{Xhsizetwocol@#1}%
\nottoggle{Xparindent@#1}{\parindent=\z@}{}%
\tolerance=5000%
\hangindent=\csuse{Xhangindent@#1}%
\everypar{\hangindent=\csuse{Xhangindent@#1}}%
***@***.***=\parindent%
\csuse{Xcolalign@#1}%
***@***.***%
\strut%
}%
But I don't see any undefined lenght. Should any of the lenghts here be defined for each specific arrangment?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I fix the error (it was just a typo). So basically now, I have a new arrangement witch is a copy of |
exactly.
twocolfootgroup push txt in two columns
parafootgroup transform the inline box to a series of paragraphed endnotes
|
I am reasing the cide at the same time than the TeXbook. At this moment, my understanding is that first I have to build the "paragraph mode" box and them push to the two columns insert. |
the paragraph mode box is created by \paravfootnote
|
I manage to typeset the footnotes in paragraph mode and with the with of two column mode. The problem now is that the footnote is not breaking across columns. Everything is typeset in one column but with half the width. (Continue improving my understanding of inserts!) |
good luck. It is I think one of the most complex topic of TeX :)
|
Would you havr some time to review my code? |
I don’t think before this week-end.
… Le 15 juin 2017 à 12:17, TeXtnik ***@***.***> a écrit :
Would you havr some time to review my code?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Ok. No problem to wait! |
After a quick review, it seems to be normal (but I don't remember all the thing which should be done). However, should not be possible to make code factoring? |
Sorry, what do you mean by normal? I done what you expect it should be done? |
Yes. I think (for the code, I don't read the commentaries) |
ps: but before doing a pull request, please
1. Adapt it the a parathreecol
2. Add documentation
3. Add version for familiarfootnote (parathreecolX)
… Le 18 juin 2017 à 14:47, TeXtnik ***@***.***> a écrit :
Sorry, what do you mean by normal? I done what you expect it should be done?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Did you run the example 1-criticalnotes.tex? You will see that my code is not running properly. |
No I didn’t.
Sorry, but for now, I have not a lot of time
|
Don't worry. I would continue digging into the code. Just let me know if you have any idea. |
What do you mean by "You will see that my code is not running properly." ? For me it runs without TeX error, but I dind'nt get the expected results. |
I send you a pull request with what you forgotten.
Please don’t accept it, but do a pull rebase, to get a cleaner historic in the code
|
I mean that the code compiles, but the result is different from what I need. All the footnotes are typeset n the left column. |
Did you see my pull request?
|
Not yet. I wull look to it tomorrow. |
Your code is working. I have to look now to the space between notes or the penalty between notes because the line numbers of some footnotes are too close to the previous footnote. Them I will
|
Ok, but be carefull about spacing to be sur that this problem is linked to the code and not that is a default setting.
Please let me know when you will commit the correction for this problem.
|
We forgot to call the macro that inserts Xparafootsep. I did that. But |
Ok,
I have added the right to you to write on this repository.
It will be simpler if you could push on the main repository (but still in the branch). I could push the changes directly in the branch, and not using a pull request.
|
Should I now create an issue655 and push my branch to this new branch? |
yes, you can. I prefer to have branch name related to issue number ;-).
It is clearer for me.
Or better, you can rename you branch
|
Done! |
Dear Maïeul, The one typeset with libertine looks quite ok, but in the one with Heros, you can see that there are some footnotes starting a new line when there is enough space in the previous. |
that is indeed strange, but for now I have honestly not time. It would be good to try with older version of ledmac to know if one of the version break this feature or not.
|
Which version do you suggest? |
Le 2017-06-28 11:53, TeXtnik a écrit :
Which version do you suggest?
--
You are receiving this because you commented.
Reply to this email directly, view it on GitHub [1], or mute the
thread [2].
*
Links:
------
[1] #655 (comment)
[2]
https://github.com/notifications/unsubscribe-auth/AAm24Eg7cjV3X9TrXUsYUvETcDFyLGlDks5sIiKSgaJpZM4N4Iae
I will try first with the older version of ledmac versionned on this
gihub repository
|
Currently, footnotes can be typeset in paragraph mode OR in two columns. An arrangement that combines this two features will be desirable.
The text was updated successfully, but these errors were encountered: