Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes in paragraph mode and two columns #655

Open
TeXtnik opened this issue Jun 13, 2017 · 34 comments
Open

Footnotes in paragraph mode and two columns #655

TeXtnik opened this issue Jun 13, 2017 · 34 comments

Comments

@TeXtnik
Copy link
Collaborator

TeXtnik commented Jun 13, 2017

Currently, footnotes can be typeset in paragraph mode OR in two columns. An arrangement that combines this two features will be desirable.

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 13, 2017

I started working in this issue in this branch. At the moment, I copied the section that defines the twocol arrangement and I change the names of the macros to use the new name of the arrangement.

I add the new arrangement to the example file 1-critical-edition.tex. It doesn't compile. The error is:

Section 1 (./1-criticalnotes.1)
! Illegal unit of measure (pt inserted).
<to be read again> 
                   =
l.58 \endnumbering
                  
? 

The output can be seen in the attached file.
1-criticalnotes.pdf

The document features a 5000 so I suspect that the error should be in the code block:

\newcommand{\twocolpara@begin@insert}[1]{%
  \normal@pars%
  \hsize \csuse{Xhsizetwocol@#1}%
  \nottoggle{Xparindent@#1}{\parindent=\z@}{}%
  \tolerance=5000%
  \hangindent=\csuse{Xhangindent@#1}%
  \everypar{\hangindent=\csuse{Xhangindent@#1}}%
  \@tempdima=\parindent%
  \csuse{Xcolalign@#1}%
  \parindent=\@tempdima%
  \strut%
}%

But I don't see any undefined lenght. Should any of the lenghts here be defined for each specific arrangment?

@maieul
Copy link
Owner

maieul commented Jun 13, 2017 via email

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 14, 2017

I fix the error (it was just a typo). So basically now, I have a new arrangement witch is a copy of twocol. So if I understand correctly from the answer in TSX convert twocolparafootgroup in a mix of twocolfootgroup and parafootgroup.

@maieul
Copy link
Owner

maieul commented Jun 14, 2017 via email

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 14, 2017

I am reasing the cide at the same time than the TeXbook. At this moment, my understanding is that first I have to build the "paragraph mode" box and them push to the two columns insert.

@maieul
Copy link
Owner

maieul commented Jun 14, 2017 via email

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 15, 2017

I manage to typeset the footnotes in paragraph mode and with the with of two column mode. The problem now is that the footnote is not breaking across columns. Everything is typeset in one column but with half the width. (Continue improving my understanding of inserts!)

@maieul
Copy link
Owner

maieul commented Jun 15, 2017 via email

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 15, 2017

Would you havr some time to review my code?

@maieul
Copy link
Owner

maieul commented Jun 15, 2017 via email

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 15, 2017

Ok. No problem to wait!

@maieul
Copy link
Owner

maieul commented Jun 18, 2017

After a quick review, it seems to be normal (but I don't remember all the thing which should be done). However, should not be possible to make code factoring?

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 18, 2017

Sorry, what do you mean by normal? I done what you expect​ it should be done?

@maieul
Copy link
Owner

maieul commented Jun 18, 2017

Yes. I think (for the code, I don't read the commentaries)

@maieul
Copy link
Owner

maieul commented Jun 18, 2017 via email

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 18, 2017

Did you run the example 1-criticalnotes.tex? You will see that my code is not running properly.

@maieul
Copy link
Owner

maieul commented Jun 19, 2017 via email

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 19, 2017

Don't worry. I would continue digging into the code. Just let me know if you have any idea.

@maieul
Copy link
Owner

maieul commented Jun 19, 2017

What do you mean by "You will see that my code is not running properly." ? For me it runs without TeX error, but I dind'nt get the expected results.

@maieul
Copy link
Owner

maieul commented Jun 19, 2017 via email

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 19, 2017

I mean that the code compiles, but the result is different from what I need. All the footnotes are typeset n the left column.

@maieul
Copy link
Owner

maieul commented Jun 19, 2017 via email

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 19, 2017

Not yet. I wull look to it tomorrow.

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 20, 2017

Your code is working. I have to look now to the space between notes or the penalty between notes because the line numbers of some footnotes are too close to the previous footnote. Them I will

  1. Code the parathreecol
  2. Add documentation
  3. Add version for familiarfootnote (parathreecolX)
    I will be a very busy this two weeks, but I will have plenty of time in July.

@maieul
Copy link
Owner

maieul commented Jun 20, 2017 via email

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 21, 2017

We forgot to call the macro that inserts Xparafootsep. I did that. But \Xafternote has no effect in the new twocolpara arrangement. Please, have a look when you have time.

@maieul
Copy link
Owner

maieul commented Jun 21, 2017 via email

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 21, 2017

Should I now create an issue655 and push my branch to this new branch?
(Still learning GitHub :-) )

@maieul
Copy link
Owner

maieul commented Jun 21, 2017 via email

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 21, 2017

Done!

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 26, 2017

Dear Maïeul,
I found that the building of the footnote paragraphs depends strongly on the font. I attach the example file 1-criticalnotes.tex prepared to load different fonts. I also attach two samples, one with TG Heros and other with Libertine.
1-criticalnotes.txt
(Github doesn't accept .tex files)

The one typeset with libertine looks quite ok, but in the one with Heros, you can see that there are some footnotes starting a new line when there is enough space in the previous.
This leads me to think that there is something wrong in the way we unbox the footnotes and build the paragraph.

1-criticalnotes-heros.pdf
1-criticalnotes-libertine.pdf

@maieul
Copy link
Owner

maieul commented Jun 26, 2017 via email

@TeXtnik
Copy link
Collaborator Author

TeXtnik commented Jun 28, 2017

Which version do you suggest?

@maieul
Copy link
Owner

maieul commented Jun 28, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants