Add an option for self-closing tags

[orgads]

Use <tag /> instead of <tag></tag>

[maik]

Hi!

Thank you very much for your suggestion. Could you, please, explain the reasoning behind your solution?

Best,
Maik

[orgads]

Sure. There is a condition text_content.nil?, which is never satisfied, because text_content is assigned an empty string in case it is empty. Looks like it was overlooked in the original implementation.

[maik]

I am afraid I still do not get your point. Currently, XmlSimple emits <tag></tag> for empty tags and you want it to emit <tag /> instead?

[orgads]

Use backticks for tags.

[maik]

Sorry, I've fixed the markup.

[orgads]

Right. I also wrote it in the commit message, but the description in github didn't show it because it wasn't backticked. I edited the description later.

[maik]

Now I got it.

I am hesitating a bit to change the default behavior, because the library is widely used and I could imagine that some people rely on the current output format. (even though we all know it is a cardinal sin to process XML without a parser)

So, I suggest not to change the current output format but to add a new option. Using this option users could change the output format, then.

[orgads]

Fair enough.

[orgads]

Done. I don't know how to update the docs. I added the option to index.html, but I'm not sure about the rest. Can you please handle it?

[maik]

Wow, that was fast and you've also written text and documentation. Thank you very much!

[orgads]

My pleasure :)

[orgads]

When do you plan to release?

[maik]

Sorry, I totally forgot that. I've pushed it to rubygems.org a minute ago.

…

On Tue, Dec 29, 2020 at 4:15 PM Orgad Shaneh ***@***.***> wrote: When do you plan to release? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#31 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFQT3JYWHCSRVBP3P5VV3SXHXALANCNFSM4VFOLYTA> .

[orgads]

Thanks :)