Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BS5] Migrating Web UI to Bootstrap 5 #4527

Merged
merged 49 commits into from
Jun 15, 2022

Conversation

FreddleSpl0it
Copy link
Collaborator

@FreddleSpl0it FreddleSpl0it commented Mar 29, 2022

This is a draft PR to show the process of the migration to Bootstrap v5.
Here is a list with most of the steps #4528
Maybe we should create a new feature branch for this.

@feldsam feldsam changed the base branch from staging to bootstrap5 March 29, 2022 13:27
@feldsam
Copy link
Member

feldsam commented Mar 29, 2022

Hi, I just created new branch bootstrap5, so we can merge to this branch partial features and when all will be done, them we merge to staging.

@feldsam
Copy link
Member

feldsam commented Mar 29, 2022

I think this plan/process should be a Issue and use PRs only for merging

@FreddleSpl0it
Copy link
Collaborator Author

I think this plan/process should be a Issue and use PRs only for merging

I've moved the list to #4528

@FreddleSpl0it
Copy link
Collaborator Author

FreddleSpl0it commented May 12, 2022

I'm having a hard time finding a proper replacement for FooTable, as it's no longer maintained and doesn't support Bootstrap 5. My suggestion was to use GridJS, but it doesn't support child rows (collapsing rows with details) and therefore not as responsive as Footable.

The only idea I have is to use a button that opens a modal with the item details that are not displayed in the table.

or maybe this jquery plugin https://datatables.net/
any other ideas?

@andryyy
Copy link
Contributor

andryyy commented May 16, 2022

I think switching to DataTables is a good idea. Seriously, DT is rock solid and well written and jQuery is just a fucking help in so many ways.

I like allans comment on this in https://datatables.net/forums/discussion/67258/will-datatables-2-0-require-jquery

@feldsam
Copy link
Member

feldsam commented May 17, 2022

Hi all, I like progress on this PR. I want to implement Datatables with AJAX pagination support. It speedup loading times on servers with plenty domains and mailboxes. I have to find time for this, but it should be easy https://datatables.net/manual/server-side

@DerLinkman
Copy link
Member

Hyped for it to see it guys! Nice work so far!

@FreddleSpl0it
Copy link
Collaborator Author

Hi all, I like progress on this PR. I want to implement Datatables with AJAX pagination support. It speedup loading times on servers with plenty domains and mailboxes. I have to find time for this, but it should be easy https://datatables.net/manual/server-side

I'd say I'll replace all the FooTables for now and then we can merge the PR into the feature branch for further development.

@FreddleSpl0it FreddleSpl0it marked this pull request as ready for review June 7, 2022 13:32
@FreddleSpl0it
Copy link
Collaborator Author

Most of it should be done. We could now push the whole thing into the bootstrap5 branch and polish/test it

@DerLinkman DerLinkman changed the base branch from bootstrap5 to feature/bootstrap5 June 15, 2022 08:55
@DerLinkman DerLinkman merged commit 5629d47 into mailcow:feature/bootstrap5 Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants