Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.0 support #119

Closed
wants to merge 1 commit into from
Closed

Add PHP 8.0 support #119

wants to merge 1 commit into from

Conversation

okdewit
Copy link
Contributor

@okdewit okdewit commented Feb 24, 2021

The official Elasticsearch PHP client now supports PHP 8.0 since v7.11.

I thought it might be a good idea to update laravel-elasticsearch as well.

I have:

  • Updated composer.json.
  • Added PHP 8.0 to the Github Actions test matrix.
  • Added Mockery 1.4.3 as a minimum to require-dev, because 1.3.* had some semver-unfriendly PHP 8 incompatibilities.

The Github Actions test workflow completes succesfully on the fork for all PHP/Laravel combinations.

Add minimum mockery version to require-dev for PHP 8 compatibility
@cviebrock cviebrock closed this Feb 28, 2021
@cviebrock
Copy link
Contributor

Thanks @okdewit ... I pushed a bunch of changes to add PHP8 support before I noticed your PR that does the same thing!

@okdewit
Copy link
Contributor Author

okdewit commented Feb 28, 2021

@cviebrock Thanks for your continued efforts on supporting this package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants