Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PSR-18 #522

Merged
merged 4 commits into from
Feb 2, 2019
Merged

Use PSR-18 #522

merged 4 commits into from
Feb 2, 2019

Conversation

Nyholm
Copy link
Collaborator

@Nyholm Nyholm commented Jan 6, 2019

HTTPlug 2.0 implements PSR-18.

@Nyholm
Copy link
Collaborator Author

Nyholm commented Jan 21, 2019

I will just update composer.json and I'll think Im done with this PR.

Reviews are welcome.

@Nyholm
Copy link
Collaborator Author

Nyholm commented Jan 21, 2019

Travis is red because of php-http/discovery#134

@Nyholm
Copy link
Collaborator Author

Nyholm commented Jan 23, 2019

This PR is ready for a review

Copy link
Collaborator

@DavidGarciaCat DavidGarciaCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @Nyholm !

@DavidGarciaCat
Copy link
Collaborator

@Nyholm could you please review the PHPStan error, so we can merge?

Cheers!

@Nyholm
Copy link
Collaborator Author

Nyholm commented Jan 23, 2019

Hm, PHPStan does not like this =)

@Nyholm Nyholm merged commit 6954b4d into mailgun:master Feb 2, 2019
@Nyholm Nyholm deleted the psr-18 branch February 3, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants