Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the first and last "parts" in multipart messages #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GREsau
Copy link

@GREsau GREsau commented Jun 4, 2017

In my experience, MailHog's MIME tab displays every email as having an empty initial part and a 2-byte final part (consisting of 2 dashes). This is because MailHog is incorrectly treating content before the initial boundary and after the final boundary as real parts. This content should be ignored, as specified by RFC 2046:

There appears to be room for additional information prior to the
first boundary delimiter line and following the final boundary
delimiter line. These areas should generally be left blank, and
implementations must ignore anything that appears before the first
boundary delimiter line or after the last one.

This PR will make MailHog ignore everything before the first multipart boundary and after the last one.

Everything before the first boundary delimiter line or after the last
one should be ignored (see RFC 2046)
@g-regor
Copy link

g-regor commented Jul 24, 2022

In my case I don't see any empty parts. Might not be wise blindly removing parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants