Fix for multiline insert queries #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgaifullin
reviewed
Nov 18, 2018
stmt_test.go
Outdated
| @@ -194,6 +194,18 @@ func (s *stmtSuite) TestFixDoubleInterpolateInStmt() { | |||
| s.NoError(rows.Close()) | |||
| } | |||
|
|
|||
| func (s *stmtSuite) TestFixMultiLineInsert() { | |||
There was a problem hiding this comment.
Please add a new testcase for test TestExecMulti.
like this:
queries = []string{"INSERT INTO data (i64) VALUES (?)", ""INSERT INTO data(\ni64\n) VALUES (\n?\n)"}
for q in queries:
//.. test case logicThere was a problem hiding this comment.
this test can be removed, since TestExecMulti covers this case
|
Thanks for your PR, there is just one comment about test case |
|
I've added a testcase |
|
LGTM, thank you for PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When insert query contains multiple lines batchmode is not working.
To fix that I have added regexp flag to match "." to "\n"