Support the UUID Column Type #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UUID type
bgaifullin
reviewed
Jan 12, 2019
dataparser.go
Outdated
| @@ -399,7 +399,7 @@ func newDataParser(t *TypeDesc, unquote bool) (DataParser, error) { | |||
| return &floatParser{32}, nil | |||
| case "Float64": | |||
| return &floatParser{64}, nil | |||
| case "String", "Enum8", "Enum16": | |||
| case "String", "Enum8", "Enum16", "UUID": | |||
|
LGTM, Please resolve conflicts with master and I will merge this PR |
@bgaifullin Branch should be up to date and mergeable - not sure what you mean? |
|
Github shows this message "This branch cannot be rebased due to conflicts". |
|
Interesting - sounds like may be wonkiness around Github caching or similar, but saw you merged another PR so remerged master and it seems to have passed tests again. I see: |
|
Seems like it was some glitch with github. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.