Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more configuration of HTTP headers (or just remove them) #31

Closed
shuffle2 opened this issue Apr 22, 2017 · 2 comments
Closed

Allow more configuration of HTTP headers (or just remove them) #31

shuffle2 opened this issue Apr 22, 2017 · 2 comments

Comments

@shuffle2
Copy link

https://github.com/mailvelope/keyserver/blob/master/src/app.js#L68
Currently keyserver adds a bunch of headers which are not really it's place to manage, especially if it's running behind a reverse proxy, which appears to be the intended scenario anyways.
For example, the current keyserver does not support serving HTTPS itself and yet it is setting HSTS and HPKP. IMO these should be handled by the reverse proxy. Any headers keyserver sets should be considered only for the [keyserver <-> reverse proxy] connection.

@Shinrai
Copy link

Shinrai commented Apr 30, 2019

Now moved to

if (util.isTrue(config.server.httpsUpgrade)) {

But yes, HSTS should either be it’s own config variable. This variable could be defaultly on and only sent when the variable is on and upgrade to https is on.

There are several reasons you don’t want HSTS. Thus this should be configurable.

@toberndo
Copy link
Member

toberndo commented Nov 7, 2023

HSTS is now controlled with the environment variable HTTP_SECURITY_HEADER and off by default.

@toberndo toberndo closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants