Introduce License client #9

dborovcanin · 2020-01-21T18:22:12Z

This pull request resolves #8.

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Introduce licensing agent. Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

golangcibot · 2020-01-21T18:23:28Z

agent/agent.go

+)
+
+type agent struct {
+	svc      string


field svc is unused (from unused)

golangcibot · 2020-01-21T18:23:28Z

cmd/agent/main.go

+
+type config struct {
+	logLevel    string
+	svcURL      string


field svcURL is unused (from unused)

golangcibot · 2020-01-21T18:23:28Z

cmd/agent/main.go

+	defServerCert  = ""
+
+	envLogLevel    = "MF_LICENSE_LOG_LEVEL"
+	envSvcURL      = "MF_LICENSE_SERVICE_URL"


envSvcURL is unused (from varcheck)

golangcibot · 2020-01-21T18:23:29Z

cmd/agent/main.go

+
+const (
+	defLogLevel    = "error"
+	defSvcURL      = "localhost:8180"


defSvcURL is unused (from varcheck)

golangcibot · 2020-01-21T18:23:29Z

agent/crypto.go

+}
+
+func mid(b string) (a string) {
+	a = b


SA4006: this value of a is never used (from staticcheck)

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

golangcibot · 2020-01-24T14:10:55Z

cmd/agent/main.go

+	a = api.NewLoggingMiddleware(a, logger)
+	go a.Do()
+
+	a.Load()


Error return value of a.Load is not checked (from errcheck)

golangcibot · 2020-01-24T14:10:55Z

cmd/agent/main.go

+	go a.Do()
+
+	a.Load()
+	a.Validate([]string{"svc1"})


Error return value of a.Validate is not checked (from errcheck)

golangcibot · 2020-01-24T14:10:55Z

cmd/agent/main.go

+
+	a.Load()
+	a.Validate([]string{"svc1"})
+	a.Save()


Error return value of a.Save is not checked (from errcheck)

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

golangcibot · 2020-01-24T14:18:35Z

agent/crypto.go

+}
+
+func mid(b string) (ret string) {
+	ret = b


SA4006: this value of ret is never used (from staticcheck)

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

drasko

Looks very good, just that I would suggest reorganization of the repo to fit Go project layout.

I will approve and let you open the issue for this reorganization.

drasko · 2020-01-24T14:57:08Z

.gitignore

@@ -1 +1,5 @@
+# Build dir contains bineries.


drasko · 2020-01-24T14:58:21Z

agent.go

@@ -0,0 +1,24 @@
+// Copyright (c) Mainflux


Why are files like this put in the root?

I am not sure that this follows these recommendations: https://github.com/golang-standards/project-layout

drasko · 2020-01-24T14:58:37Z

agent/agent.go

@@ -0,0 +1,181 @@
+// Copyright (c) Mainflux


Should go in pkg probably

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

* Add client interface Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Create Agent interface Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Update project layout Introduce licensing agent. Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Add watch method to Agent Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Add comments to exported errors Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Add main method for Agent Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Remove commented code Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Add logging middleware Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Use channels and commands for synchronization Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Fix GitHub flow Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Fix Agent interface Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Handler non-existing license file Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Close channel by sender, not receiver Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Remove buffer size from error and command channels Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Use single errors channel Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Use HTTP client to get a License from the cloud Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Add cloud URL to configuration Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Remove Fetch method Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Fix typo in .gitignore Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

dborovcanin added 10 commits December 24, 2019 14:35

Add client interface

eee8d70

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Create Agent interface

fa3a9b8

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Update project layout

7dc65e2

Introduce licensing agent. Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Add watch method to Agent

3b1a2c9

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Add comments to exported errors

bc513e3

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Add main method for Agent

fd1a5d4

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Remove commented code

d6514aa

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Add logging middleware

d1db874

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Use channels and commands for synchronization

152ef97

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Fix GitHub flow

b931dc2

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

dborovcanin added the WIP Work in progress label Jan 21, 2020

dborovcanin self-assigned this Jan 21, 2020

dborovcanin changed the title ~~Introduce License client (#8)~~ Introduce License client Jan 21, 2020

golangcibot reviewed Jan 21, 2020

View reviewed changes

dborovcanin added 6 commits January 22, 2020 17:49

Fix Agent interface

269c506

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Handler non-existing license file

66dd76e

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Close channel by sender, not receiver

46486e4

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Remove buffer size from error and command channels

1e3070c

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Use single errors channel

91d866a

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

Use HTTP client to get a License from the cloud

ae3a5c1

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

golangcibot reviewed Jan 24, 2020

View reviewed changes

dborovcanin force-pushed the 8 branch from 6784c09 to bfc5ed9 Compare January 24, 2020 14:16

Add cloud URL to configuration

bfc5ed9

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

golangcibot reviewed Jan 24, 2020

View reviewed changes

agent/crypto.go

}

func mid(b string) (ret string) {

ret = b

Copy link

golangcibot Jan 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SA4006: this value of ret is never used (from staticcheck)

dborovcanin removed the WIP Work in progress label Jan 24, 2020

Remove Fetch method

57a7067

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

drasko previously approved these changes Jan 24, 2020

View reviewed changes

Fix typo in .gitignore

416c346

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

dborovcanin dismissed drasko’s stale review via 416c346 January 24, 2020 15:20

dborovcanin merged commit dca5216 into master Jan 24, 2020

manuio deleted the 8 branch January 24, 2020 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce License client #9

Introduce License client #9

dborovcanin commented Jan 21, 2020

golangcibot Jan 21, 2020

golangcibot Jan 21, 2020

golangcibot Jan 21, 2020

golangcibot Jan 21, 2020

golangcibot Jan 21, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

drasko left a comment

drasko Jan 24, 2020

drasko Jan 24, 2020

drasko Jan 24, 2020

Introduce License client #9

Introduce License client #9

Conversation

dborovcanin commented Jan 21, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drasko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment