NOISSUE - Fix title #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarcetic
approved these changes
Mar 3, 2021
drasko
reviewed
Mar 3, 2021
There was a problem hiding this comment.
@nmarcetic please do not merge when you see unresolved comment.
I demanded that title is corrected to Mfxkit - Mainflux Starter Kit, and that we remove lines Mfx-kit and mfx-kit - please use without dash in the middle.
@darkodraskovic can you please correct and send new PR?
|
|
||
| ## How-to | ||
|
|
||
| Copy `mfxkit` directory to the `mainflux` root directory, e.g. `~/go/src/github.com/mainflux/mainflux/`. Copy `cmd/mfxkit` directory to `mainflux/cmd` directory. | ||
| Copy `mfx-kit` directory to the `mainflux` root directory, e.g. `~/go/src/github.com/mainflux/mainflux/`. Copy `cmd/mfxkit` directory to `mainflux/cmd` directory. |
There was a problem hiding this comment.
Ah, I see now this is service / gopackage name. Sorry then, maybe we can keep.old name - I prefer one word mfxkit.
Maybe just add in title Mfxkit - Mainflux Starter Kit, and that's all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darko Draskovic darko.draskovic@gmail.com