Send a given cookie name only once per fastboot response #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, every time something calls write() a new Set-Cookie header gets added for fastboot. So if you do:
The response headers are sent as:
And all that is sent in the response back to the client/browser, which then ignores all but the last set for a given key. ember-simple-auth in particular does several sets of the same key and ends up constantly sending multiple values for the same cookie.
This PR changes
write()
->_writeFastBootCookie(name, value)
to look for an existingset-cookie
header forname
and replace the existing entry's value with the new one if found, instead of always appending a new entry.