Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Node 6 #321

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Drop support for Node 6 #321

merged 2 commits into from
Sep 25, 2019

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Sep 25, 2019

…as it is EOL.

Turbo87
Turbo87 approved these changes Sep 25, 2019
View reviewed changes
Copy link
Collaborator

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep in mind that this is a breaking change when releasing this. in other words: this needs a new major version release, or since we're still pre-1.0 minor version should be sufficient, aka. v0.5.0

package.json Outdated Show resolved Hide resolved
@marcoow @Turbo87
Update package.json
81db4c3 
Co-Authored-By: Tobias Bieniek <tobias.bieniek@gmail.com>
@marcoow
Copy link
Member Author

marcoow commented Sep 25, 2019

Yep, was going to release this as 0.5.0

@marcoow marcoow merged commit c5edcfb into master Sep 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the node-8 branch September 25, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoow @Turbo87