Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-2419 Prevent deadlock #44

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Conversation

luksa
Copy link
Contributor

@luksa luksa commented Jan 11, 2023

No description provided.

@luksa
Copy link
Contributor Author

luksa commented Jan 11, 2023

@jwendell what's wrong here.. looks like the builder image is missing something?

@jwendell
Copy link
Member

I think we need b697cfb in 2.3

@jwendell
Copy link
Member

@luksa can you cherry-pick it as part of this PR as a separate commit? You can try it locally using the 2.3 builder image too.

@luksa
Copy link
Contributor Author

luksa commented Jan 11, 2023

@jwendell we need to keep go mod vendor, right (b697cfb removes it)?

@jwendell
Copy link
Member

jwendell commented Jan 11, 2023

@jwendell we need to keep go mod vendor, right (b697cfb removes it)?

That commit itself doesn't remove it I think. I tried to keep commits separated in 2.4 PR (#40). That said, yeah, maybe you need to do some adjustments for 2.3.

@luksa
Copy link
Contributor Author

luksa commented Jan 11, 2023

make gen previously did a go mod vendor, but the commit removes this... I've now modified the cherry-picked commit so it still runs go mod vendor.

@jwendell
Copy link
Member

make gen previously did a go mod vendor, but the commit removes this... I've now modified the cherry-picked commit so it still runs go mod vendor.

Thanks, that was my mistake. That removal should be part of the other commit that removes vendor dir.

@luksa
Copy link
Contributor Author

luksa commented Jan 11, 2023

@jwendell I think that change now makes everything worse :)

@jwendell
Copy link
Member

ok, let me try it locally

@luksa luksa force-pushed the OSSM-2419-2.3 branch 2 times, most recently from b55328d to b219eda Compare January 11, 2023 18:44
@maistra-bot maistra-bot merged commit 3d1d3c4 into maistra:maistra-2.3 Jan 11, 2023
@luksa
Copy link
Contributor Author

luksa commented Jan 11, 2023

Oops, forgot the don't squash label... but too late now.

luksa added a commit to luksa/api that referenced this pull request Jan 24, 2023
)"

This reverts parts of commit 3d1d3c4 (specifically the changes that were cherry-picked from commit maistra@b697cfb)
luksa added a commit to luksa/api that referenced this pull request Jan 24, 2023
maistra#44)"

This reverts parts of commit 3d1d3c4 (specifically the changes that were cherry-picked from commit maistra@b697cfb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants