WIP: Stop leaking goroutines in newMultiWatch #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that watches are also closed by the API Server every few minutes. That's another case where Watch() is called again without a new List(). |
luksa
reviewed
Sep 3, 2019
dgn
force-pushed
the
stop-leaking
branch
2 times, most recently
from
9ecbdd3
to
266a664
Compare
That's correct, but the leak is only triggered when Watch() fails and is not followed by either a call to Stop() or List(). The reflector will in fact call Stop() before calling Watch() again in that case. |
This fixes a goroutine leak in cases where Watch() is called again without a new List() inbetween Watch() calls. This happens when one of the underlying watches returns a ConnectionRefused error. See https://github.com/kubernetes/client-go/blob/3fe2abece89efc7b3a2da0ff549525f20f435263/tools/cache/reflector.go#L286
dgn
pushed a commit
to dgn/istio-maistra
that referenced
this pull request
Jan 28, 2020
* don't use mtls for bookinfo destination rules Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Signed-off-by: Ralf Pannemans <ralf.pannemans@sap.com> * Remove old webhook when switching controlplanes Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Signed-off-by: Ralf Pannemans <ralf.pannemans@sap.com> * Switch control planes after update Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Signed-off-by: Ralf Pannemans <ralf.pannemans@sap.com> * Add owner reference to webhook Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Signed-off-by: Ralf Pannemans <ralf.pannemans@sap.com>
dgn
pushed a commit
to dgn/istio-maistra
that referenced
this pull request
Jan 28, 2020
This initial take on the prow infrastructure is targeted at linting to begin with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a goroutine leak in cases where Watch() is called again without a new List() inbetween Watch() calls. This happens when one of the underlying watches returns a ConnectionRefused error. See https://github.com/kubernetes/client-go/blob/3fe2abece89efc7b3a2da0ff549525f20f435263/tools/cache/reflector.go#L286
Note that I stumbled upon this leak while fixing another bug; this probably has other implications, so I'll mark it WIP for now.