MAISTRA-1282 Disable Envoy's panic mode as default (#15609) #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Fix] retain CommonLbConfig for HealthyPanicThreshold (#13682) * retain the HealthyPanicThreshold field even if it's set to 0 for disabling Envoy's panic mode (#13682) * fix a comment and add a test for disabling panic threshold as default * run go fmt * run gofmt -s * reword a comment * remove link
jwendell
approved these changes
Mar 19, 2020
|
Marking as WIP because the test is currently failing |
|
Closing as this is included in later releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straight cherry-pick from upstream, no conflicts