Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #779
The variable
$physical_memory
is correctly assigned fromforcemem
and converted to bytes early insub os_setup
(line 523).But then on line 598 it is reassigned (overwritten) from a
forcemem
value, if existing, without converting it to bytes.This leads to a problem when converted/rounded back to KB, MB or GB in
hr_bytes
. Now because of the reassignment$physical_memory
has the MB value, buthr_bytes
treats that value as bytes.This will lead to incorrectly determining the Physical memory. For example if a user passes
--forcemem 2000
, thehr_bytes
will convert that to 2.0K, thinking 2000 is bytes, and the result in the console will be:And ultimately because of this,
mysqltuner
will give wrong suggestions about the memory consumption: