feat: do not spawn a thread for num_thread=1
#216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spawning of a single thread on my computer produces a huge time overhead.
Thus I propose to add an if clause that would lead to no multithreading when
num_thread=1
is used. This is already implemented for the case when multiple inputs are used, but isn't for the case when a single string is being input to.augment()
.I have benchmarked with the following code:
For the
dev
version ofnlpaug
it results in the delta time of0.10184303998947143
, while the proposed version results in9.496212005615235e-05
, which makes huge difference.