-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : Tiptap integration #1832
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR focuses on transitioning from Remirror to Tiptap, implementing new features, and fixing bugs. It includes the addition of bubble menu support, slash command support, improved file structure with prosemirror plugins, image upload functionality, and integration of Tiptap with all Remirror instances.
Tiptap.basic.demo.mov
Changes in Detail
Remirror to Tiptap Transition
The transition from Remirror to Tiptap involved
react-hook-form
html
instead of Prosemirror JSON!Bubble Menu Support
Allowing users to access various formatting options easily with:
syntax highlighting
Slash Command Support
Enabling users to quickly insert nodes like:
Saving with Debounce Logic
Debounce logic was added to save user input after a 500ms delay when the user stops typing. This change improved the saving process, which previously relied on the editor's blur state that could be very unreliable.
tiptap.debounce.logic.mov
Image Uploads and File Structure Improvements
reorder images
within the editor.image
so that I can trigger a function to delete it on the backend as wellScreen.Recording.2023-08-08.at.6.23.01.PM.mov
Tiptap Integration with Various Components
Additional Context
The PR also includes various improvements and bug fixes, such as resolving conflicting keyboard shortcuts supporting
markdown
shortcuts, and implementing a "Saved" state for image uploads with placeholder while uploading..