Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: command k modal #2803

Merged
merged 4 commits into from
Nov 21, 2023
Merged

refactor: command k modal #2803

merged 4 commits into from
Nov 21, 2023

Conversation

aaryan610
Copy link
Collaborator

@aaryan610 aaryan610 commented Nov 20, 2023

This PR focuses on refactoring the command k modal file structuring and code-level improvements

Fix-

  1. Project identifier search not working properly.
Screen.Recording.2023-11-21.at.1.06.08.PM.mov

Refactor-

  1. Created separate files for different command groups.
  2. Updated the useSWR logic with the new MobX store logic.

Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
plane ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 7:36am
plane-dev ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 7:36am
plane-sh ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 7:36am
plane-sh-dev ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 7:36am
plane-sh-stage ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 7:36am
plane-staging ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 7:36am

@aaryan610 aaryan610 marked this pull request as ready for review November 21, 2023 07:37
@sriramveeraghanta sriramveeraghanta merged commit 7aaf840 into develop Nov 21, 2023
10 of 12 checks passed
@sriramveeraghanta sriramveeraghanta deleted the refactor/command_k branch November 21, 2023 10:16
sriramveeraghanta pushed a commit that referenced this pull request Dec 7, 2023
* refactor: command palette file structure

* fix: identifier search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants