Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix env substitute issue in websocket docker setup #3296

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Fix env substitute issue in websocket docker setup #3296

merged 6 commits into from
Jan 10, 2024

Conversation

abidkhan484
Copy link
Contributor

No description provided.

@mguptahub mguptahub merged commit a70f551 into makeplane:preview Jan 10, 2024
3 of 6 checks passed
@abidkhan484 abidkhan484 deleted the fix-websocket-docker-setup branch January 10, 2024 11:52
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
@abidkhan484 @mguptahub @sriramveeraghanta
Fix env substitute issue in websocket docker setup (#3296)
fff6ee6 
* fix websocket connection issue in docker #3195

* fix websocket connection issue for local env with removing from the prod nginx conf template #319

* fix env substitution issue  of proxy_set_header #3196

* review fixes

---------

Co-authored-by: Manish Gupta <manish@mgupta.me>
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
@abidkhan484 @mguptahub @sriramveeraghanta
Fix env substitute issue in websocket docker setup (#3296)
38580c3 
* fix websocket connection issue in docker #3195

* fix websocket connection issue for local env with removing from the prod nginx conf template #319

* fix env substitution issue  of proxy_set_header #3196

* review fixes

---------

Co-authored-by: Manish Gupta <manish@mgupta.me>
This was referenced Feb 19, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@04023401 04023401 04023401 left review comments

@mguptahub mguptahub mguptahub approved these changes

Assignees
No one assigned
Labels
⚙️config changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abidkhan484 @04023401 @mguptahub @sriramveeraghanta