Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-517] bug: workspace view navbar scroll to view improvement #3771

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[WEB-517] bug: workspace view navbar scroll to view improvement #3771

merged 1 commit into from
Feb 23, 2024

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Feb 23, 2024 •
edited by pushya22
Loading

Problem:

  1. An odd overflow animation occurs for the last views when choosing a view from the views navbar.
  2. Upon reloading, the view header fails to reload to the current view.

Solution:

  1. Implemented specific conditions to prevent this undesired behavior.
  2. Adjusted the dependencies array within the useEffect hook to ensure proper functionality upon reloading.

Issue link: [WEB-517]

@anmolsinghbhatia anmolsinghbhatia added this to the v0.16 milestone Feb 23, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 23, 2024
View reviewed changes
web/components/workspace/views/header.tsx Dismissed Show dismissed Hide dismissed
web/components/workspace/views/header.tsx Dismissed Show dismissed Hide dismissed
@pushya22 pushya22 changed the title [WEB-517] chore: workspace view header scroll to view improvement [WEB-517] chore: workspace view navbar scroll to view improvement Feb 23, 2024
@pushya22 pushya22 changed the title [WEB-517] chore: workspace view navbar scroll to view improvement [WEB-517] bug: workspace view navbar scroll to view improvement Feb 23, 2024
@pushya22 pushya22 requested review from gurusainath and removed request for rahulramesha February 23, 2024 10:54
@sriramveeraghanta sriramveeraghanta merged commit 8c1f169 into develop Feb 23, 2024
8 of 9 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/workspace-view-improvement branch February 23, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurusainath gurusainath gurusainath approved these changes

@sriramveeraghanta sriramveeraghanta Awaiting requested review from sriramveeraghanta

Assignees
No one assigned
Labels
🐛bug Something isn't working 🌐frontend 🌟improvement 🎨UI / UX
Projects
None yet
Milestone
v0.16-dev
Development

Successfully merging this pull request may close these issues.
3 participants
@anmolsinghbhatia @gurusainath @sriramveeraghanta