Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-1126] fix: inbox issue attachment upload #4341

Merged
merged 1 commit into from
May 2, 2024
Merged

[WEB-1126] fix: inbox issue attachment upload #4341

merged 1 commit into from
May 2, 2024

Conversation

aaryan610
Copy link
Collaborator

Problem:

  1. In inbox issues, trying to upload an attachment in any of the issues uploads that attachment to the first loaded issue.

Solution:

  1. Updated the dependencies of the useCallback hook to updated the issueId on change of issue.

Plane issue: WEB-1126

@aaryan610 aaryan610 added 🐛bug Something isn't working 🌐frontend labels May 2, 2024
@aaryan610 aaryan610 added this to the v0.19-dev milestone May 2, 2024
@aaryan610 aaryan610 changed the title [WEB-1126] chore: update useCallback dependencies [WEB-1126] chore: update useCallback dependencies May 2, 2024
@aaryan610 aaryan610 changed the title [WEB-1126] chore: update useCallback dependencies [WEB-1126] fix: inbox issue attachment upload May 2, 2024
@sriramveeraghanta sriramveeraghanta merged commit 45c9dfb into preview May 2, 2024
11 of 12 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/attachment-upload branch May 2, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

@gurusainath gurusainath Awaiting requested review from gurusainath

Assignees
No one assigned
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Milestone
v0.19-dev
Development

Successfully merging this pull request may close these issues.
2 participants
@aaryan610 @sriramveeraghanta