feat: add pages and page blocks #495
Conversation
iamsahebgiri
commented
Mar 22, 2023
iamsahebgiri
commented
- Created the page UI as per design.
- Implemented add page to favorite and remove page from favorite.
- Can able to update and delete page
- Can able to create, update and delete page blocks.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| }; | ||
|
|
||
| const createPage = async (payload: IPageForm) => { | ||
| payload = { |
There was a problem hiding this comment.
Why do we need this line?
| .createPage(workspaceSlug as string, projectId as string, payload) | ||
| .then(() => { | ||
| mutate(PAGE_LIST(projectId as string)); | ||
| handleClose(); |
There was a problem hiding this comment.
Change this to onClose()
| const handleDeletion = async () => { | ||
| setIsDeleteLoading(true); | ||
| if (!data || !workspaceSlug) return; | ||
| console.log(data); |
There was a problem hiding this comment.
Remove this console.log
| }); | ||
| }) | ||
| .catch((error) => { | ||
| console.log(error); |
There was a problem hiding this comment.
Add a toast alert to handle this error
| query: { workspaceSlug, projectId, pageId }, | ||
| } = useRouter(); | ||
|
|
||
| const handleMouseEnter = () => { |
There was a problem hiding this comment.
Use tailwind group to handle the hover events.
apps/app/services/pages.service.ts
Outdated
| workspaceSlug: string, | ||
| projectId: string, | ||
| pageId: string, | ||
| data: IPageForm |
There was a problem hiding this comment.
data needs to be Partial for the patch request
apps/app/services/pages.service.ts
Outdated
| projectId: string, | ||
| pageId: string, | ||
| pageBlockId: string, | ||
| data: IPageBlockForm |
There was a problem hiding this comment.
data needs to be Partial for the patch request
- used tailwind for hover events - add error toast alert - used partial for patch request
| className="border-none bg-transparent outline-none" | ||
| /> | ||
|
|
||
| <div className="absolute top-[50%] right-0 z-20 mr-2 hidden translate-y-[-50%] group-hover:block"> |
There was a problem hiding this comment.
We don't need to use absolute positioning, just flex justify between would be fine
There was a problem hiding this comment.
yeah I have fixed it
