-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: state creation from external apis #5345
Conversation
WalkthroughThe recent update enhances the serialization process within the API by adding a new field, Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant API
participant Serializer
Client->>API: Request data
API->>Serializer: Serialize data
Serializer->>Serializer: Include "deleted_at" field
Serializer->>API: Return serialized data
API->>Client: Send response with "deleted_at"
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apiserver/plane/api/serializers/state.py (1 hunks)
Additional comments not posted (1)
apiserver/plane/api/serializers/state.py (1)
26-26
: Ensure Consistency with Model Fields.The addition of
"deleted_at"
toread_only_fields
is appropriate if this field is managed by the system and should not be modified by API clients. Verify that theState
model includes adeleted_at
field and that it is intended to be read-only.
Summary by CodeRabbit
deleted_at
timestamp, enabling better handling of deleted entities.