Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-2225] fix: placeholder for list items #5389

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Palanikannan1437
Copy link
Collaborator

@Palanikannan1437 Palanikannan1437 commented Aug 20, 2024

Description

Fix the placeholder text for list items.

Summary by CodeRabbit

  • New Features

    • Introduced enhanced placeholder styles in the ProseMirror editor for improved user guidance.
    • Added specific placeholder text formatting for empty paragraphs, enhancing clarity in text input areas.
  • Bug Fixes

    • Removed outdated placeholder styles to streamline the user interface and improve functionality.

Copy link
Contributor

coderabbitai bot commented Aug 20, 2024

Walkthrough

The recent changes enhance the ProseMirror editor's usability by introducing a dedicated style for placeholder text in empty paragraphs. By refining how placeholders are displayed, users receive clearer visual guidance when interacting with the editor, ensuring a more intuitive typing experience. This adjustment focuses on paragraph-level placeholders, streamlining previous, more generalized rules.

Changes

Files Change Summary
packages/editor/src/styles/editor.css Introduced new placeholder styles for empty paragraphs in ProseMirror; replaced general placeholder rule with a specific rule for paragraphs, improving user guidance and interaction.

Poem

In the editor's space, so bright and wide,
A placeholder's glow, like a rabbit's guide.
With every new line, a whisper of cheer,
"Type here, dear friend, your thoughts we hold dear!"
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Palanikannan1437 Palanikannan1437 marked this pull request as ready for review August 20, 2024 08:56
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6748065 and 57bd9cf.

Files selected for processing (1)
  • packages/editor/src/styles/editor.css (3 hunks)
Additional context used
GitHub Check: Codacy Static Code Analysis
packages/editor/src/styles/editor.css

[notice] 92-92: packages/editor/src/styles/editor.css#L92
(selector) => Expected class selector "${selector}" to be kebab-case

Additional comments not posted (1)
packages/editor/src/styles/editor.css (1)

Line range hint 82-87: LGTM!

The CSS rule for displaying placeholders in the first line of an empty editor is correctly implemented. It uses data-placeholder and ensures non-interference with user interactions.

packages/editor/src/styles/editor.css Show resolved Hide resolved
@SatishGandham SatishGandham merged commit d9b0fe2 into preview Aug 20, 2024
20 of 22 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/placeholder-text-double branch August 27, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants