-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-2225] fix: placeholder for list items #5389
Conversation
WalkthroughThe recent changes enhance the ProseMirror editor's usability by introducing a dedicated style for placeholder text in empty paragraphs. By refining how placeholders are displayed, users receive clearer visual guidance when interacting with the editor, ensuring a more intuitive typing experience. This adjustment focuses on paragraph-level placeholders, streamlining previous, more generalized rules. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/editor/src/styles/editor.css (3 hunks)
Additional context used
GitHub Check: Codacy Static Code Analysis
packages/editor/src/styles/editor.css
[notice] 92-92: packages/editor/src/styles/editor.css#L92
(selector) =>Expected class selector "${selector}" to be kebab-case
Additional comments not posted (1)
packages/editor/src/styles/editor.css (1)
Line range hint
82-87
: LGTM!The CSS rule for displaying placeholders in the first line of an empty editor is correctly implemented. It uses
data-placeholder
and ensures non-interference with user interactions.
Description
Fix the placeholder text for list items.
Summary by CodeRabbit
New Features
Bug Fixes