feat: issue attachments feature #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
anmolsinghbhatia
commented
Apr 5, 2023
anmolsinghbhatia
commented
- attachment functionality added in issue detail page.
- toast alert on add or remove of attachment.
- loading & deleting state added.
- file validation added.
- dynamic file icon added.
- mutation improvement.
- responsiveness improvement.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vihar
changed the title
aaryan610
reviewed
Apr 6, 2023
apps/app/helpers/date-time.helper.ts
Outdated
| @@ -173,3 +176,37 @@ export const renderShortTime = (date: string | Date) => { | |||
|
|
|||
| export const isDateRangeValid = (startDate: string, endDate: string) => | |||
| new Date(startDate) < new Date(endDate); | |||
|
|
|||
| export const formatDateLong = (dateString: string) => { | |||
There was a problem hiding this comment.
Change the function name according to the convention we're following.
aaryan610
reviewed
Apr 6, 2023
apps/app/services/file.service.ts
Outdated
| @@ -32,6 +32,51 @@ class FileServices extends APIService { | |||
| super(NEXT_PUBLIC_API_BASE_URL || "http://localhost:8000"); | |||
| } | |||
|
|
|||
| async uploadIssueAttachment( | |||
There was a problem hiding this comment.
Move the services to issue.service file
aaryan610
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.