Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View only scratch function to expose liquidation penalty #133

Closed
wants to merge 1 commit into from

Conversation

yaronvel
Copy link
Contributor

I would kindly ask that the cat would expose the tab calculation as a public function.
A similar function exists in compound as an API (in their smart contract).

The motivation is that we are working on an opt-in liquidation system that needs to read the liquidation penalty value from makerdao’s cat.
We plan to read the cat address from the end contract, but changes like in this version, where the chop resolution changed from rad to wad will break our system (in the future, it is still not deployed).
Hence, a function that for a given art returns the tab, would really help.

@gbalabasquer
Copy link
Contributor

rate and chop are public values, that can be read from external contracts and do the math there directly

@yaronvel
Copy link
Contributor Author

@gbalabasquer it is true that they are public. but chop is about to change from ray to wad resolution.
Which means it will not always enough to just read it.

Having it as an "official" api, like all other lending platform offer, would make it easier to integrate.

@kmbarry1
Copy link
Contributor

Feature request addressed by: #155

@kmbarry1 kmbarry1 closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants